[Lldb-commits] [lldb] [LLDB] Add allow_var_updates to DIL and CanUpdateVar to SetValueFromInteger (PR #186421)
via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 24 08:17:06 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/include/lldb/Target/BorrowedStackFrame.h lldb/include/lldb/Target/StackFrame.h lldb/include/lldb/ValueObject/DILEval.h lldb/include/lldb/ValueObject/ValueObject.h lldb/source/Commands/CommandObjectFrame.cpp lldb/source/Plugins/Process/scripted/ScriptedFrame.cpp lldb/source/Plugins/Process/scripted/ScriptedFrame.h lldb/source/Target/BorrowedStackFrame.cpp lldb/source/Target/StackFrame.cpp lldb/source/ValueObject/DILEval.cpp lldb/source/ValueObject/ValueObject.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lldb/source/ValueObject/ValueObject.cpp b/lldb/source/ValueObject/ValueObject.cpp
index d3d573f43..be44ce986 100644
--- a/lldb/source/ValueObject/ValueObject.cpp
+++ b/lldb/source/ValueObject/ValueObject.cpp
@@ -1280,7 +1280,8 @@ void ValueObject::SetValueFromInteger(lldb::ValueObjectSP new_val_sp,
} else if (HasFloatingRepresentation(new_val_type)) {
auto value_or_err = new_val_sp->GetValueAsAPFloat();
if (value_or_err)
- SetValueFromInteger(value_or_err->bitcastToAPInt(), error, can_update_var);
+ SetValueFromInteger(value_or_err->bitcastToAPInt(), error,
+ can_update_var);
else
error = Status::FromErrorString("error getting APFloat from new_val_sp");
} else if (new_val_type.IsPointerType()) {
@@ -1292,7 +1293,8 @@ void ValueObject::SetValueFromInteger(lldb::ValueObjectSP new_val_sp,
if (auto temp = llvm::expectedToOptional(
new_val_sp->GetCompilerType().GetBitSize(target.get())))
num_bits = temp.value();
- SetValueFromInteger(llvm::APInt(num_bits, int_val), error, can_update_var);
+ SetValueFromInteger(llvm::APInt(num_bits, int_val), error,
+ can_update_var);
} else
error = Status::FromErrorString("error converting new_val_sp to integer");
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/186421
More information about the lldb-commits
mailing list