[Lldb-commits] [lldb] [lldb][Linux] Read memory protection keys for memory regions (PR #182246)

[David Spickett via lldb-commits]

================
@@ -12,14 +12,14 @@ using namespace lldb_private;
 
 llvm::raw_ostream &lldb_private::operator<<(llvm::raw_ostream &OS,
                                             const MemoryRegionInfo &Info) {
-  return OS << llvm::formatv("MemoryRegionInfo([{0}, {1}), {2:r}{3:w}{4:x}, "
-                             "{5}, `{6}`, {7}, {8}, {9}, {10}, {11})",
-                             Info.GetRange().GetRangeBase(),
-                             Info.GetRange().GetRangeEnd(), Info.GetReadable(),
-                             Info.GetWritable(), Info.GetExecutable(),
-                             Info.GetMapped(), Info.GetName(), Info.GetFlash(),
-                             Info.GetBlocksize(), Info.GetMemoryTagged(),
-                             Info.IsStackMemory(), Info.IsShadowStack());
+  return OS << llvm::formatv(
----------------
DavidSpickett wrote:

Blame part of that on C++'s lack of named keywords, but I agree it's ridiculous.

I will look for a better approach (one that applies generally, not just for this PR).

https://github.com/llvm/llvm-project/pull/182246