[Lldb-commits] [lldb] 79f3104 - [lldb] Fix warning style for SymStore symbol locator (#187776)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 20 14:53:00 PDT 2026
Author: Nerixyz
Date: 2026-03-20T22:52:56+01:00
New Revision: 79f3104e09e8c7885a1cf12743562c83819af7d7
URL: https://github.com/llvm/llvm-project/commit/79f3104e09e8c7885a1cf12743562c83819af7d7
DIFF: https://github.com/llvm/llvm-project/commit/79f3104e09e8c7885a1cf12743562c83819af7d7.diff
LOG: [lldb] Fix warning style for SymStore symbol locator (#187776)
Missed this when reviewing #186986. This fixes the warnings to follow
the [LLVM Coding
Standards](https://llvm.org/docs/CodingStandards.html#error-and-warning-messages).
Added:
Modified:
lldb/source/Plugins/SymbolLocator/SymStore/SymbolLocatorSymStore.cpp
Removed:
################################################################################
diff --git a/lldb/source/Plugins/SymbolLocator/SymStore/SymbolLocatorSymStore.cpp b/lldb/source/Plugins/SymbolLocator/SymStore/SymbolLocatorSymStore.cpp
index 884519b54acfd..ffadaace97b4c 100644
--- a/lldb/source/Plugins/SymbolLocator/SymStore/SymbolLocatorSymStore.cpp
+++ b/lldb/source/Plugins/SymbolLocator/SymStore/SymbolLocatorSymStore.cpp
@@ -192,7 +192,7 @@ requestFileFromSymStoreServerHTTP(llvm::StringRef base_url, llvm::StringRef key,
// Make sure URL will be valid, portable, and compatible with symbol servers.
if (has_unsafe_characters(pdb_name)) {
Debugger::ReportWarning(llvm::formatv(
- "Rejecting HTTP lookup for PDB file due to unsafe characters in "
+ "rejecting HTTP lookup for PDB file due to unsafe characters in "
"name: {0}",
pdb_name));
return {};
@@ -201,13 +201,13 @@ requestFileFromSymStoreServerHTTP(llvm::StringRef base_url, llvm::StringRef key,
// Construct the path for local storage. Configurable cache coming soon.
llvm::SmallString<128> cache_file;
if (!path::cache_directory(cache_file)) {
- Debugger::ReportWarning("Failed to determine cache directory for SymStore");
+ Debugger::ReportWarning("failed to determine cache directory for SymStore");
return {};
}
path::append(cache_file, "lldb", "SymStore", pdb_name, key);
if (std::error_code ec = fs::create_directories(cache_file)) {
Debugger::ReportWarning(
- llvm::formatv("Failed to create cache directory '{0}': {1}", cache_file,
+ llvm::formatv("failed to create cache directory '{0}': {1}", cache_file,
ec.message()));
return {};
}
More information about the lldb-commits
mailing list