[Lldb-commits] [lldb] [lldb-dap][windows] don't use the ConPTY in internalConsole mode (PR #186472)

[Charles Zablit via lldb-commits]

================
@@ -132,6 +132,10 @@ FLAGS_ENUM(LaunchFlags){
                     ///< permissions but instead inherit them from its parent.
     eLaunchFlagMemoryTagging =
         (1u << 13), ///< Launch process with memory tagging explicitly enabled.
+    eLaunchFlagUsePipes =
+        (1u << 14), ///< Use anonymous pipes for stdio instead of a ConPTY on
+                    ///< Windows. Useful when terminal emulation is not needed
+                    ///< (e.g. lldb-dap internalConsole mode).
----------------
charles-zablit wrote:

Let's keep `eLaunchFlagUsePipes` generic then, i.e without Windows in the name.
Should the comment be more explicit that this only works on Windows?
```cpp
///< Use anonymous pipes for stdio instead of a ConPTY on
///< Windows. Useful when terminal emulation is not needed
///< (e.g. lldb-dap internalConsole mode).
```

https://github.com/llvm/llvm-project/pull/186472