[Lldb-commits] [lldb] [lldb][Process/FreeBSDKernelCore] Remove interactive mode check (PR #186705)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Minsoo Choo (mchoo7)

<details>
<summary>Changes</summary>

`Debugger.GetCommandInterpreter().IsInteractive()` is flaky thus `ProcessFreeBSDKernelCore::PrintUnreadMessage()` returns early due to incorrect behaviour. Disable the interactive mode check until it is fixed.

---
Full diff: https://github.com/llvm/llvm-project/pull/186705.diff


1 Files Affected:

- (modified) lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp (+4-2) 


``````````diff
diff --git a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
index d1a4a1ebc47d7..fbe9157b4f9a9 100644
--- a/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
+++ b/lldb/source/Plugins/Process/FreeBSD-Kernel-Core/ProcessFreeBSDKernelCore.cpp
@@ -394,8 +394,10 @@ void ProcessFreeBSDKernelCore::PrintUnreadMessage() {
   Target &target = GetTarget();
   Debugger &debugger = target.GetDebugger();
 
-  if (!debugger.GetCommandInterpreter().IsInteractive())
-    return;
+  // Todo: GetCommandInterpreter().IsInteractive() is flaky. When it is
+  // stabilized, restore the following code.
+  // if (!debugger.GetCommandInterpreter().IsInteractive())
+  //   return;
 
   Status error;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/186705