[Lldb-commits] [lldb] [LLDB][Accelerators][1/M] Scaffold a basic Mock plugin for testing accelerator flows (PR #186535)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions c,h,cpp -- lldb/test/API/accelerator/mock/main.c lldb/tools/lldb-server/LLDBServerPluginRegistry.cpp lldb/tools/lldb-server/LLDBServerPluginRegistry.h lldb/tools/lldb-server/Plugins/Accelerator/LLDBServerPluginAccelerator.cpp lldb/tools/lldb-server/Plugins/Accelerator/LLDBServerPluginAccelerator.h lldb/tools/lldb-server/Plugins/Accelerator/Mock/LLDBServerPluginMockAccelerator.cpp lldb/tools/lldb-server/Plugins/Accelerator/Mock/LLDBServerPluginMockAccelerator.h lldb/tools/lldb-server/lldb-gdbserver.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/tools/lldb-server/LLDBServerPluginRegistry.cpp b/lldb/tools/lldb-server/LLDBServerPluginRegistry.cpp
index d76579baf..ec1725685 100644
--- a/lldb/tools/lldb-server/LLDBServerPluginRegistry.cpp
+++ b/lldb/tools/lldb-server/LLDBServerPluginRegistry.cpp
@@ -27,8 +27,8 @@ void LLDBServerPluginRegistry::Initialize() {
            [](LLDBServerPluginAccelerator::GDBServer &gdb_server,
               lldb_private::MainLoop &main_loop)
                -> std::unique_ptr<LLDBServerPluginAccelerator> {
-             return std::make_unique<LLDBServerPluginMockAccelerator>(gdb_server,
-                                                                      main_loop);
+             return std::make_unique<LLDBServerPluginMockAccelerator>(
+                 gdb_server, main_loop);
            });
 }
 
diff --git a/lldb/tools/lldb-server/Plugins/Accelerator/LLDBServerPluginAccelerator.h b/lldb/tools/lldb-server/Plugins/Accelerator/LLDBServerPluginAccelerator.h
index 4f816df2e..9e6bc5d4f 100644
--- a/lldb/tools/lldb-server/Plugins/Accelerator/LLDBServerPluginAccelerator.h
+++ b/lldb/tools/lldb-server/Plugins/Accelerator/LLDBServerPluginAccelerator.h
@@ -9,8 +9,8 @@
 #ifndef LLDB_TOOLS_LLDB_SERVER_PLUGINS_ACCELERATOR_LLDBSERVERPLUGINACCELERATOR_H
 #define LLDB_TOOLS_LLDB_SERVER_PLUGINS_ACCELERATOR_LLDBSERVERPLUGINACCELERATOR_H
 
-#include "llvm/ADT/StringRef.h"
 #include "lldb/Host/MainLoop.h"
+#include "llvm/ADT/StringRef.h"
 
 namespace lldb_private {
 
diff --git a/lldb/tools/lldb-server/Plugins/Accelerator/Mock/LLDBServerPluginMockAccelerator.cpp b/lldb/tools/lldb-server/Plugins/Accelerator/Mock/LLDBServerPluginMockAccelerator.cpp
index e9c641582..f4c0711aa 100644
--- a/lldb/tools/lldb-server/Plugins/Accelerator/Mock/LLDBServerPluginMockAccelerator.cpp
+++ b/lldb/tools/lldb-server/Plugins/Accelerator/Mock/LLDBServerPluginMockAccelerator.cpp
@@ -29,7 +29,7 @@ bool LLDBServerPluginMockAccelerator::TryActivate() {
   // Activate the plugin by writing the parent PID to the test file
   std::error_code ec;
   llvm::raw_fd_ostream out("/tmp/accelerator_plugin_test.txt", ec,
-                          llvm::sys::fs::OF_Text);
+                           llvm::sys::fs::OF_Text);
   out << llvm::sys::Process::getProcessId() << '\n';
 
   return true;
diff --git a/lldb/tools/lldb-server/lldb-gdbserver.cpp b/lldb/tools/lldb-server/lldb-gdbserver.cpp
index 77d099b76..b028714e3 100644
--- a/lldb/tools/lldb-server/lldb-gdbserver.cpp
+++ b/lldb/tools/lldb-server/lldb-gdbserver.cpp
@@ -455,7 +455,7 @@ int main_gdbserver(int argc, char *argv[]) {
   // Ensure plugins are torn down on all exit paths (RAII cleanup).
   llvm::scope_exit teardown_plugins([&]() {
     for (auto &plugin : accelerator_plugins)
-        plugin->Teardown();
+      plugin->Teardown();
   });
 
   llvm::StringRef host_and_port;

``````````

</details>


https://github.com/llvm/llvm-project/pull/186535