[Lldb-commits] [lldb] [lldb-dap][windows] don't use the ConPTY in internalConsole mode (PR #186472)

[Charles Zablit via lldb-commits]

================
@@ -132,6 +132,10 @@ FLAGS_ENUM(LaunchFlags){
                     ///< permissions but instead inherit them from its parent.
     eLaunchFlagMemoryTagging =
         (1u << 13), ///< Launch process with memory tagging explicitly enabled.
+    eLaunchFlagUsePipes =
+        (1u << 14), ///< Use anonymous pipes for stdio instead of a ConPTY on
+                    ///< Windows. Useful when terminal emulation is not needed
+                    ///< (e.g. lldb-dap internalConsole mode).
----------------
charles-zablit wrote:

I thought about doing an `#ifdef _WIN32` but that does not sound right in an enum.

I think that indicating it only works on Windows in the name makes sense. Will it ever matter if we change the name in the future if Unix ever needs that?

https://github.com/llvm/llvm-project/pull/186472