[Lldb-commits] [lldb] [lldb-dap][windows] don't use the ConPTY in internalConsole mode (PR #186472)

[Charles Zablit via lldb-commits]

================
@@ -162,6 +166,64 @@ void PseudoConsole::ClosePipes() {
   m_conpty_output = INVALID_HANDLE_VALUE;
 }
 
+void PseudoConsole::CloseChildHandles() {
+  if (m_pipe_child_stdin != INVALID_HANDLE_VALUE)
+    CloseHandle(m_pipe_child_stdin);
+  if (m_pipe_child_stdout != INVALID_HANDLE_VALUE)
+    CloseHandle(m_pipe_child_stdout);
+
+  m_pipe_child_stdin = INVALID_HANDLE_VALUE;
+  m_pipe_child_stdout = INVALID_HANDLE_VALUE;
+}
+
+llvm::Error PseudoConsole::OpenAnonymousPipes() {
----------------
charles-zablit wrote:

This is very similar to the logic of `PseudoConsole::OpenPseudoConsole()`. Maybe the 2 methods could be simplified to use a single helper method.

https://github.com/llvm/llvm-project/pull/186472