[Lldb-commits] [lldb] [lldb] Preserve TargetSP in Platform module lookup (PR #186323)

[Jonas Devlieghere via lldb-commits]

================
@@ -255,7 +255,7 @@ Status ModuleCache::Get(const FileSpec &root_dir_spec, const char *hostname,
   cached_module_spec.GetPlatformFileSpec() = module_spec.GetFileSpec();
 
   error = ModuleList::GetSharedModule(cached_module_spec, cached_module_sp,
-                                      nullptr, did_create_ptr);
+                                      nullptr, did_create_ptr, false);
   if (error.Fail())
     return error;
 
----------------
JDevlieghere wrote:

Can you also explain why this needed to be updated? It doesn't look like the new code is checking this, so I assume it's in response to something not expecting to inherit the target?

https://github.com/llvm/llvm-project/pull/186323