[Lldb-commits] [lldb] [lldb][Module][NFC] Use raw string literal and formatv-style format in LoadScriptingResourceInTarget (PR #186411)
Adrian Prantl via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 13 08:14:50 PDT 2026
================
@@ -1467,13 +1467,18 @@ bool Module::LoadScriptingResourceInTarget(Target *target, Status &error,
continue;
if (should_load == eLoadScriptFromSymFileWarn) {
- feedback_stream.Printf(
- "warning: '%s' contains a debug script. To run this script in this "
- "debug session:\n\n command script import \"%s\"\n\nTo run all "
- "discovered debug scripts in this session:\n\nsettings set "
- "target.load-script-from-symbol-file true\n",
- GetFileSpec().GetFileNameStrippingExtension().GetCString(),
- scripting_fspec.GetPath().c_str());
+ feedback_stream.Format(R"(
+warning: '{0}' contains a debug script. To run this script in this debug session:
----------------
adrian-prantl wrote:
1. I think this should be a `note:` rather than a warning?
2. It would be really nice if we could return structured diagnostics here so we don't need to hardcode the warning type (and have it uncolored, for example).
3. "To run this script in this debug session" -> "To import this script (or make this script available) in this debug session"
https://github.com/llvm/llvm-project/pull/186411
More information about the lldb-commits
mailing list