[Lldb-commits] [lldb] [llvm] Reland "[Support] Move HTTP client/server to new LLVMSupportHTTP lib (NFC)" (PR #186074)

[Martin Storsjö via lldb-commits]

mstorsjo wrote:

Yes, I can confirm that this commit (5eaf19a151296f770a1a2bd8514a76530234d933) is what breaks it.

But the build breakage on mingw configurations only happens with CMake 3.31 or newer, for some strange reason.

It's possible to observe the same linking issue on Linux as well; configure the build with `-DLLVM_LINK_LLVM_DYLIB=ON`. When linking `lib/liblldb.so.23.0.0git`, previously the command didn't reference linking `lib/libLLVMSupport.a` at all, it only referenced `lib/libLLVM.so.23.0git`. Now after this change, it links `lib/libLLVMSupportHTTP.a  lib/libLLVMSupport.a`.

My guess would be that `LLVMSupportHTTP` also needs to be folded into the dylib, and attempts to link that library also should go to the dylib, so it doesn't try to link it manually. And/or if this already is the case, it's also possible that instead of
```
  LINK_LIBS
    LLVMSupport
```
you need to do
```
  LINK_COMPONENTS
    Support
```
when these libraries are referenced in LLDB. (Or the same for `SupportHTTP`)

https://github.com/llvm/llvm-project/pull/186074