[Lldb-commits] [lldb] Reland "[lldb] Initial plugin and test for SymbolLocatorSymStore" (PR #185658)

[Stefan Gränitz via lldb-commits]

================
@@ -71,6 +71,9 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,
 
   // If the module specified a filespec, use that.
   FileSpec fspec = module_sp->GetSymbolFileFileSpec();
+  // Otherwise, use the PDB path from CodeView.
+  if (!fspec)
+    fspec = obj_file->GetPDBPath().value_or(FileSpec());
----------------
weliveindetail wrote:

> It would be great if we can test that we load the PDB from the expected path.

I moved the log into `CalculateAbilities()` so we issue it in any case and reverted my test change. Ok? https://github.com/llvm/llvm-project/pull/185658/changes/4a2facdb024dd8ed18e3045e647e84d419d4c4be

> I wonder if we still need `findMatchingPDBFilePath`. It might be used in some tests.

Yeah, I don't think it's in scope for this PR.

https://github.com/llvm/llvm-project/pull/185658