[Lldb-commits] [lldb] [lldb] Fix Windows build by adding missing link dependencies (PR #186014)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Omair Javaid (omjavaid)

<details>
<summary>Changes</summary>

PR #<!-- -->184656 (08cef699c4bb) moved LoadCore and DebuggerSupportsLLVMTarget into TestUtilities.cpp but did not update CMakeLists.txt to add the new link dependencies.

This fixes the broken lldb unit test build on Windows because lld was throwing unresolved external symbol errors on Windows and required all symbols to be resolved explicitly.

---
Full diff: https://github.com/llvm/llvm-project/pull/186014.diff


1 Files Affected:

- (modified) lldb/unittests/TestingSupport/CMakeLists.txt (+2) 


``````````diff
diff --git a/lldb/unittests/TestingSupport/CMakeLists.txt b/lldb/unittests/TestingSupport/CMakeLists.txt
index b9affcf41217f..d2dccf5eefde0 100644
--- a/lldb/unittests/TestingSupport/CMakeLists.txt
+++ b/lldb/unittests/TestingSupport/CMakeLists.txt
@@ -6,8 +6,10 @@ add_lldb_library(lldbUtilityHelpers
   LINK_COMPONENTS
     Support
     ObjectYAML
+    TestingSupport
   LINK_LIBS
     lldbUtility
+    liblldb
     llvm_gtest
   )
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/186014