[Lldb-commits] [lldb] Reland "[lldb] Initial plugin and test for SymbolLocatorSymStore" (PR #185658)

[via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/185658 at github.com>


================
@@ -71,6 +71,9 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,
 
   // If the module specified a filespec, use that.
   FileSpec fspec = module_sp->GetSymbolFileFileSpec();
+  // Otherwise, use the PDB path from CodeView.
+  if (!fspec)
+    fspec = obj_file->GetPDBPath().value_or(FileSpec());
----------------
Nerixyz wrote:

> It simply failed because it was testing for a log output that isn't emitted anymore.

It would be great if we can test that we load the PDB from the expected path. For example [here](https://github.com/llvm/llvm-project/blob/d00ed836e77759414afd40c02eeca5651657438f/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp#L318). We won't be able to output the associated .exe, but at least we'd have a string like "Loading foo.pdb" that we can check for.

> * The traversal of `target.debug-file-search-paths`, which should now be [covered in SymbolLocatorDefault](https://github.com/llvm/llvm-project/blob/d00ed836e77759414afd40c02eeca5651657438f/lldb/source/Plugins/SymbolLocator/Default/SymbolLocatorDefault.cpp#L195).

That's great! I wonder if we still need `findMatchingPDBFilePath`. It might be used in some tests.

https://github.com/llvm/llvm-project/pull/185658