[Lldb-commits] [lldb] Reland "[lldb] Initial plugin and test for SymbolLocatorSymStore" (PR #185658)

[via lldb-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/185658 at github.com>


================
@@ -71,6 +71,9 @@ SymbolVendorPECOFF::CreateInstance(const lldb::ModuleSP &module_sp,
 
   // If the module specified a filespec, use that.
   FileSpec fspec = module_sp->GetSymbolFileFileSpec();
+  // Otherwise, use the PDB path from CodeView.
+  if (!fspec)
+    fspec = obj_file->GetPDBPath().value_or(FileSpec());
----------------
Nerixyz wrote:

(I think) because we set the symbol path here, the following `SymbolFile/` shell tests are failing:

```
Failed Tests (7):
  lldb-shell :: SymbolFile/NativePDB/find-pdb-next-to-exe.test
  lldb-shell :: SymbolFile/NativePDB/symtab.cpp
  lldb-shell :: SymbolFile/PDB/expressions.test
  lldb-shell :: SymbolFile/PDB/native-setting.cpp
  lldb-shell :: SymbolFile/PDB/udt-layout.test
  lldb-shell :: SymbolFile/PDB/variables-locations.test
  lldb-shell :: SymbolFile/PDB/vbases.test
```

You might need to replicate/move what we do here: https://github.com/llvm/llvm-project/blob/be021b84331df17d3fc1a613d0bf35d34bb1d609/lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp#L89-L121

https://github.com/llvm/llvm-project/pull/185658