[Lldb-commits] [lldb] [lldb][PlatformDarwin][NFC] Factor sanitization of Python module names into helper function (PR #185627)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 10 08:37:51 PDT 2026


Michael137 wrote:

> Why was this code in PlatformDarwin to begin with? I don't think the rules for legal python file names are Python specific, are they? This seems like something the ScriptInterpreter should offer as a virtual function, and the actual implementation should be in ScriptInterpreterPython.cpp.
> 
> If the fix for the FIXME was to move this to a better place, I'm fine with this as an intermediate step. But I can't see why this belongs where it is now in the long run.

Yea i agree with that. I'm just moving it around/simplifying it for now as part of trying to re-use it for something else. Moving it to ScriptInterpreter eventually makes sense

https://github.com/llvm/llvm-project/pull/185627


More information about the lldb-commits mailing list