[Lldb-commits] [lldb] [lldb][PlatformDarwin][NFC] Move logic to emit warning on invalid/conflicting Python script names into helper function (PR #185669)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 33348 tests passed
* 501 tests skipped
* 4 tests failed

## Failed Tests
(click on a test name to see its output)

### lldb-unit
<details>
<summary>lldb-unit.Platform/_/LLDBPlatformTests/PlatformDarwinLocateTest/LocateExecutableScriptingResourcesFromDSYM_ModuleNameIsKeyword_Match</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/unittests/Platform/./LLDBPlatformTests --gtest_filter=PlatformDarwinLocateTest.LocateExecutableScriptingResourcesFromDSYM_ModuleNameIsKeyword_Match
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Platform/PlatformDarwinTest.cpp:399
Expected equality of these values:
  ss.GetString()
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-ac2399/.dSYM/Contents/Resources/Python/import.py'. However, its name conflicts with a keyword and as such cannot be loaded. LLDB will load '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-ac2399/.dSYM/Contents/Resources/Python/_import.py' instead. Consider removing the file with the malformed name to eliminate this warning.\n"
  expected
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-ac2399/.dSYM/Contents/Resources/DWARF/../Python/import.py'. However, its name conflicts with a keyword and as such cannot be loaded. LLDB will load '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-ac2399/.dSYM/Contents/Resources/DWARF/../Python/_import.py' instead. Consider removing the file with the malformed name to eliminate this warning.\n"


```
</details>
<details>
<summary>lldb-unit.Platform/_/LLDBPlatformTests/PlatformDarwinLocateTest/LocateExecutableScriptingResourcesFromDSYM_ModuleNameIsKeyword_NoMatch</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/unittests/Platform/./LLDBPlatformTests --gtest_filter=PlatformDarwinLocateTest.LocateExecutableScriptingResourcesFromDSYM_ModuleNameIsKeyword_NoMatch
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Platform/PlatformDarwinTest.cpp:359
Expected equality of these values:
  ss.GetString()
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-c98f14/.dSYM/Contents/Resources/Python/import.py'. However, its name conflicts with a keyword and as such cannot be loaded. If you intend to have this script loaded, please rename it to '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-c98f14/.dSYM/Contents/Resources/Python/_import.py' and retry.\n"
  expected
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-c98f14/.dSYM/Contents/Resources/DWARF/../Python/import.py'. However, its name conflicts with a keyword and as such cannot be loaded. If you intend to have this script loaded, please rename it to '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-c98f14/.dSYM/Contents/Resources/DWARF/../Python/_import.py' and retry.\n"


```
</details>
<details>
<summary>lldb-unit.Platform/_/LLDBPlatformTests/PlatformDarwinLocateTest/LocateExecutableScriptingResourcesFromDSYM_SpecialCharactersInModuleName_Match_Warning</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/unittests/Platform/./LLDBPlatformTests --gtest_filter=PlatformDarwinLocateTest.LocateExecutableScriptingResourcesFromDSYM_SpecialCharactersInModuleName_Match_Warning
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Platform/PlatformDarwinTest.cpp:507
Expected equality of these values:
  ss.GetString()
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-6dc5f2/.dSYM/Contents/Resources/Python/TestModule-1.1 1.py'. However, its name contains reserved characters and as such cannot be loaded. LLDB will load '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-6dc5f2/.dSYM/Contents/Resources/Python/TestModule_1_1_1.py' instead. Consider removing the file with the malformed name to eliminate this warning.\n"
  expected
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-6dc5f2/.dSYM/Contents/Resources/DWARF/../Python/TestModule-1.1 1.py'. However, its name contains reserved characters and as such cannot be loaded. LLDB will load '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-6dc5f2/.dSYM/Contents/Resources/DWARF/../Python/TestModule_1_1_1.py' instead. Consider removing the file with the malformed name to eliminate this warning.\n"


```
</details>
<details>
<summary>lldb-unit.Platform/_/LLDBPlatformTests/PlatformDarwinLocateTest/LocateExecutableScriptingResourcesFromDSYM_SpecialCharactersInModuleName_NoMatch</summary>

```
Script:
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/unittests/Platform/./LLDBPlatformTests --gtest_filter=PlatformDarwinLocateTest.LocateExecutableScriptingResourcesFromDSYM_SpecialCharactersInModuleName_NoMatch
--
/home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/unittests/Platform/PlatformDarwinTest.cpp:466
Expected equality of these values:
  ss.GetString()
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-e752a8/.dSYM/Contents/Resources/Python/TestModule-1.1 1.py'. However, its name contains reserved characters and as such cannot be loaded. If you intend to have this script loaded, please rename it to '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-e752a8/.dSYM/Contents/Resources/Python/TestModule_1_1_1.py' and retry.\n"
  expected
    Which is: "warning: found a debug script '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-e752a8/.dSYM/Contents/Resources/DWARF/../Python/TestModule-1.1 1.py'. However, its name contains reserved characters and as such cannot be loaded. If you intend to have this script loaded, please rename it to '/tmp/lit-tmp-vath6tjk/locate-scripts-from-dsym-test-e752a8/.dSYM/Contents/Resources/DWARF/../Python/TestModule_1_1_1.py' and retry.\n"


```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/185669