[Lldb-commits] [lldb] [LLDB] Modify CreateValueObjectFrom* to take an ExecutionContext (PR #185547)

Ilia Kuklin via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 10 05:39:34 PDT 2026


================
@@ -132,7 +132,7 @@ TEST_F(FormatterSectionTest, LoadFormattersForModule) {
 
   std::string dest;
   ValueObjectSP valobj = ValueObjectConstResult::CreateValueObjectFromBool(
-      m_target_sp, false, "mock");
+      ExecutionContext(m_target_sp.get(), false), false, "mock");
----------------
kuilpd wrote:

I think the test is failing because `CreateValueObjectFromBool` allowed to create a value even if there are no `target->GetScratchTypeSystems()`, and it was still created but with an empty `CompilerType`. Now it doesn't create the value if a type system isn't found, which makes more sense, so maybe the test should be adjusted instead.

https://github.com/llvm/llvm-project/pull/185547


More information about the lldb-commits mailing list