[Lldb-commits] [lldb] [lldb] Turn on OSC 9; 4 graphical progress in supported terminals (PR #185541)

[David Spickett via lldb-commits]

================
@@ -2077,6 +2077,30 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) {
   m_forward_listener_sp.reset();
 }
 
+/// Conservative heuristic to detect whether OSC 9;4 progress is supported by
+/// the current terminal.
+static bool TerminalSupportsOSCProgress() {
+  static std::once_flag g_once_flag;
+  static bool g_supports_osc_progress = false;
+
+  std::call_once(g_once_flag, []() {
+    std::array<const char *, 4> g_known_env_vars = {
----------------
DavidSpickett wrote:

Feels like a list of things "the terminal authors told me not to rely on", but we know how that sentiment performs in reality :)

In the best case, where a standard thing is added, this function can be extended to support that too.

https://github.com/llvm/llvm-project/pull/185541