[Lldb-commits] [lldb] [llvm] [MC] Move MCTargetOptions pointer from MCContext to MCAsmInfo (PR #180464)

[Fangrui Song via lldb-commits]

================
@@ -155,6 +155,9 @@ BinaryContext::BinaryContext(std::unique_ptr<MCContext> Ctx,
       STI(std::move(STI)), InstPrinter(std::move(InstPrinter)),
       MIA(std::move(MIA)), MIB(std::move(MIB)), MRI(std::move(MRI)),
       DisAsm(std::move(DisAsm)), Logger(Logger), InitialDynoStats(isAArch64()) {
+  // createMCAsmInfo stored a pointer to a local MCTargetOptions in MCAsmInfo.
+  // Update it to point to our member that will outlive MCAsmInfo.
+  const_cast<MCAsmInfo *>(this->AsmInfo.get())->setTargetOptions(MCOptions);
----------------
MaskRay wrote:

I believe no unless we want to do a large refactoring to bolt (which I want to avoid).

https://github.com/llvm/llvm-project/pull/180464