[Lldb-commits] [lldb] [lldb] Declare types of Python synthetic signatures (NFC) (PR #184914)

[Dave Lee via lldb-commits]

https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/184914

>From 1a33e6eebc7c1a1b8c44f5892acba9368765d10d Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Thu, 5 Mar 2026 15:16:41 -0800
Subject: [PATCH 1/2] [lldb] Declare types of Python synthetic signatures (NFC)

---
 lldb/source/Commands/CommandObjectType.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lldb/source/Commands/CommandObjectType.cpp b/lldb/source/Commands/CommandObjectType.cpp
index f8b87e267776f..846bd29ccab5c 100644
--- a/lldb/source/Commands/CommandObjectType.cpp
+++ b/lldb/source/Commands/CommandObjectType.cpp
@@ -289,11 +289,11 @@ class CommandObjectTypeSummaryAdd : public CommandObjectParsed,
 static const char *g_synth_addreader_instructions =
     "Enter your Python command(s). Type 'DONE' to end.\n"
     "You must define a Python class with these methods:\n"
-    "    def __init__(self, valobj, internal_dict):\n"
-    "    def num_children(self):\n"
-    "    def get_child_at_index(self, index):\n"
-    "    def get_child_index(self, name):\n"
-    "    def update(self):\n"
+    "    def __init__(self, valobj: lldb.SBValue, internal_dict):\n"
+    "    def num_children(self) -> int:\n"
+    "    def get_child_at_index(self, index: int) -> lldb.SBValue:\n"
+    "    def get_child_index(self, name: str) -> int:\n"
+    "    def update(self) -> int | None:\n"
     "        '''Optional'''\n"
     "class synthProvider:\n";
 

>From 59acd552edad46e5844acc57c955b6b87f354c84 Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Fri, 6 Mar 2026 10:00:06 -0800
Subject: [PATCH 2/2] Update lldb/source/Commands/CommandObjectType.cpp

Co-authored-by: Ebuka Ezike <yerimyah1 at gmail.com>
---
 lldb/source/Commands/CommandObjectType.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/source/Commands/CommandObjectType.cpp b/lldb/source/Commands/CommandObjectType.cpp
index 846bd29ccab5c..60a695c04ad95 100644
--- a/lldb/source/Commands/CommandObjectType.cpp
+++ b/lldb/source/Commands/CommandObjectType.cpp
@@ -291,9 +291,9 @@ static const char *g_synth_addreader_instructions =
     "You must define a Python class with these methods:\n"
     "    def __init__(self, valobj: lldb.SBValue, internal_dict):\n"
     "    def num_children(self) -> int:\n"
-    "    def get_child_at_index(self, index: int) -> lldb.SBValue:\n"
+    "    def get_child_at_index(self, index: int) -> lldb.SBValue | None:\n"
     "    def get_child_index(self, name: str) -> int:\n"
-    "    def update(self) -> int | None:\n"
+    "    def update(self) -> bool:\n"
     "        '''Optional'''\n"
     "class synthProvider:\n";