[Lldb-commits] [lldb] [lldb] Initial plugin and test for SymbolLocatorSymStore (PR #183302)

[Stefan Gränitz via lldb-commits]

weliveindetail wrote:

Thanks for the fast replies and suggestions! I checked the `MAKE_PDB` issue again and I think I found why LLDB had loaded the test inferior as DWARF without it.

Since we cannot disable the DWARF test-case, the test skips it explicitly in the Python script. However, this only happened after the inferior had already been built. Apparently, the skip causes the cleanup logic not to run. (What is the  default behavior here anyway?) The remaining artifacts haven't been recreated fully during the subsequent run of the PDB test-case. It seems that the `MAKE_PDB` directive was hiding that, at least for me locally. On the bot this might have cause the problem.

My assumption is that the issue will be fixed with the above patch. It simply skips the DWARF test before it builds the inferior. That way it works for me locally without `MAKE_PDB`. I think this is the better approach anyway, so this might be fine to fix forward.

https://github.com/llvm/llvm-project/pull/183302