[Lldb-commits] [lldb] b989713 - [lldb][windows] remove sleep before closing ConPTY (#183539)

[via lldb-commits]

Author: Charles Zablit
Date: 2026-03-05T19:50:42+01:00
New Revision: b989713cd2980037c90dfba4bcf233c984284085

URL: https://github.com/llvm/llvm-project/commit/b989713cd2980037c90dfba4bcf233c984284085
DIFF: https://github.com/llvm/llvm-project/commit/b989713cd2980037c90dfba4bcf233c984284085.diff

LOG: [lldb][windows] remove sleep before closing ConPTY (#183539)

Added: 
    

Modified: 
    lldb/source/Host/windows/PseudoConsole.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Host/windows/PseudoConsole.cpp b/lldb/source/Host/windows/PseudoConsole.cpp
index 03ebabc2d8f75..da4b1310ea17c 100644
--- a/lldb/source/Host/windows/PseudoConsole.cpp
+++ b/lldb/source/Host/windows/PseudoConsole.cpp
@@ -138,10 +138,6 @@ bool PseudoConsole::IsConnected() const {
 }
 
 void PseudoConsole::Close() {
-  Sleep(50); // FIXME: This mitigates a race condition when closing the
-             // PseudoConsole. It's possible that there is still data in the
-             // pipe when we try to close it. We should wait until the data has
-             // been consumed.
   SetStopping(true);
   std::unique_lock<std::mutex> guard(m_mutex);
   if (m_conpty_handle != INVALID_HANDLE_VALUE)