[Lldb-commits] [lldb] [lldb-dap] Fix valueLocationReference in setVariable request (PR #184782)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Sergei Druzhkov (DrSergei)

<details>
<summary>Changes</summary>

Fixed small typo. We always send invalidated event, so it is not a real problem.

---
Full diff: https://github.com/llvm/llvm-project/pull/184782.diff


1 Files Affected:

- (modified) lldb/tools/lldb-dap/Handler/SetVariableRequestHandler.cpp (+1-1) 


``````````diff
diff --git a/lldb/tools/lldb-dap/Handler/SetVariableRequestHandler.cpp b/lldb/tools/lldb-dap/Handler/SetVariableRequestHandler.cpp
index 725d5de094c95..736d41b6555dc 100644
--- a/lldb/tools/lldb-dap/Handler/SetVariableRequestHandler.cpp
+++ b/lldb/tools/lldb-dap/Handler/SetVariableRequestHandler.cpp
@@ -81,7 +81,7 @@ SetVariableRequestHandler::Run(const SetVariableArguments &args) const {
     body.memoryReference = addr;
 
   if (ValuePointsToCode(variable))
-    body.valueLocationReference = new_var_ref.AsUInt32();
+    body.valueLocationReference = PackLocation(new_var_ref.AsUInt32(), true);
 
   // Also send invalidated event to signal client that some variables
   // (e.g. references) can be changed.

``````````

</details>


https://github.com/llvm/llvm-project/pull/184782