[Lldb-commits] [lldb] [lldb] Fix feature format in DisassemblerLLVMC constructor (PR #184355)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp b/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
index d9804c2f8..f4a9adadc 100644
--- a/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
+++ b/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
@@ -1465,8 +1465,7 @@ bool DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
   return InstrDesc.isAuthenticated() || IsBrkC47x;
 }
 
-static std::string& strip_trailing_comma(std::string& features_str)
-{
+static std::string &strip_trailing_comma(std::string &features_str) {
   // We should delete the last comma from string.
   if (!features_str.empty() && features_str.back() == ',')
     features_str.pop_back();
@@ -1629,8 +1628,9 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec &arch,
   // We use m_disasm_up.get() to tell whether we are valid or not, so if this
   // isn't good for some reason, we won't be valid and FindPlugin will fail and
   // we won't get used.
-  m_disasm_up = MCDisasmInstance::Create(triple_str, cpu, strip_trailing_comma(features_str).c_str(),
-                                         flavor, *this);
+  m_disasm_up = MCDisasmInstance::Create(
+      triple_str, cpu, strip_trailing_comma(features_str).c_str(), flavor,
+      *this);
 
   llvm::Triple::ArchType llvm_arch = triple.getArch();
 
@@ -1639,7 +1639,8 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec &arch,
   if (llvm_arch == llvm::Triple::arm) {
     std::string thumb_triple(thumb_arch.GetTriple().getTriple());
     m_alternate_disasm_up = MCDisasmInstance::Create(
-        thumb_triple.c_str(), "", strip_trailing_comma(features_str).c_str(), flavor, *this);
+        thumb_triple.c_str(), "", strip_trailing_comma(features_str).c_str(),
+        flavor, *this);
     if (!m_alternate_disasm_up)
       m_disasm_up.reset();
 
@@ -1652,7 +1653,8 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec &arch,
       features_str += "+micromips,";
 
     m_alternate_disasm_up = MCDisasmInstance::Create(
-        triple_str, cpu, strip_trailing_comma(features_str).c_str(), flavor, *this);
+        triple_str, cpu, strip_trailing_comma(features_str).c_str(), flavor,
+        *this);
     if (!m_alternate_disasm_up)
       m_disasm_up.reset();
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/184355