[Lldb-commits] [lldb] [LLDB] Skip linker symbols test on Windows and MacOS. (PR #184690)

[via lldb-commits]

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/184690

>From 55ac54d8713f43b5c8c808ba4d15a34ac7ed0d2b Mon Sep 17 00:00:00 2001
From: Caroline Tice <cmtice at google.com>
Date: Wed, 4 Mar 2026 14:12:24 -0800
Subject: [PATCH 1/4] [LLDB] Skip linker symbols test on Windows and MacOS.

---
 lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
index 364ac44c97917..7cbd0ea263075 100644
--- a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
+++ b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
@@ -14,6 +14,8 @@ class TestLinkerSymbols(TestBase):
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
+    @skipIf(oslist=["darwin", "macos"])
+    @skipIfWindows
     def test_linker_symbols(self):
         build_dict = dict(LD_EXTRAS="-Wl,-T," + self.getSourcePath("linker.script"))
         self.build(dictionary=build_dict)

>From 32f0466a4e0a7091bb620c7ef6bee3e719f35086 Mon Sep 17 00:00:00 2001
From: Caroline Tice <cmtice at google.com>
Date: Wed, 4 Mar 2026 14:22:16 -0800
Subject: [PATCH 2/4] Update test to only run on linux.

---
 lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
index 7cbd0ea263075..b4031757accad 100644
--- a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
+++ b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
@@ -14,8 +14,7 @@ class TestLinkerSymbols(TestBase):
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
-    @skipIf(oslist=["darwin", "macos"])
-    @skipIfWindows
+    @skipIf(oslist=nomatch(["linux"]))
     def test_linker_symbols(self):
         build_dict = dict(LD_EXTRAS="-Wl,-T," + self.getSourcePath("linker.script"))
         self.build(dictionary=build_dict)

>From 08a52d34d25c620ac337804e2a54ed6187ac1ee1 Mon Sep 17 00:00:00 2001
From: Caroline Tice <cmtice at google.com>
Date: Wed, 4 Mar 2026 14:23:47 -0800
Subject: [PATCH 3/4] Fix typo.

---
 lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
index b4031757accad..4d95d53a98904 100644
--- a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
+++ b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
@@ -14,7 +14,7 @@ class TestLinkerSymbols(TestBase):
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
-    @skipIf(oslist=nomatch(["linux"]))
+    @skipIf(oslist=no_match(["linux"]))
     def test_linker_symbols(self):
         build_dict = dict(LD_EXTRAS="-Wl,-T," + self.getSourcePath("linker.script"))
         self.build(dictionary=build_dict)

>From c19d78f3cbbcc81ce9569a23fdeec85741256ec5 Mon Sep 17 00:00:00 2001
From: Caroline Tice <cmtice at google.com>
Date: Wed, 4 Mar 2026 14:34:04 -0800
Subject: [PATCH 4/4] Make reviewer recommended change.

---
 lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
index 4d95d53a98904..bc21a08feec68 100644
--- a/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
+++ b/lldb/test/API/linux/linker-symbols/TestLinkerSymbols.py
@@ -14,7 +14,7 @@ class TestLinkerSymbols(TestBase):
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
-    @skipIf(oslist=no_match(["linux"]))
+    @skipUnlessPlatform(["linux"])
     def test_linker_symbols(self):
         build_dict = dict(LD_EXTRAS="-Wl,-T," + self.getSourcePath("linker.script"))
         self.build(dictionary=build_dict)