[Lldb-commits] [lldb] [lldb] Fixing the python_api/block tests. (PR #184647)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

<details>
<summary>Changes</summary>

Renaming the file to be unique and updating the symbols for Windows.

---
Full diff: https://github.com/llvm/llvm-project/pull/184647.diff


3 Files Affected:

- (renamed) lldb/test/API/python_api/block/TestFrameBlocks.py (+1-1) 
- (modified) lldb/test/API/python_api/block/fn.c (+7-1) 
- (modified) lldb/test/API/python_api/block/main.c (+4) 


``````````diff
diff --git a/lldb/test/API/python_api/block/TestBlocks.py b/lldb/test/API/python_api/block/TestFrameBlocks.py
similarity index 98%
rename from lldb/test/API/python_api/block/TestBlocks.py
rename to lldb/test/API/python_api/block/TestFrameBlocks.py
index d5e7a5eeef49e..923cc4a79462a 100644
--- a/lldb/test/API/python_api/block/TestBlocks.py
+++ b/lldb/test/API/python_api/block/TestFrameBlocks.py
@@ -8,7 +8,7 @@
 from lldbsuite.test import lldbutil
 
 
-class BlockAPITestCase(TestBase):
+class FrameBlocksTestCase(TestBase):
     def test_block_equality(self):
         """Exercise SBBlock equality checks across frames and functions in different dylibs."""
         self.build()
diff --git a/lldb/test/API/python_api/block/fn.c b/lldb/test/API/python_api/block/fn.c
index 80ea7e5baa11e..84716517bea29 100644
--- a/lldb/test/API/python_api/block/fn.c
+++ b/lldb/test/API/python_api/block/fn.c
@@ -1,4 +1,10 @@
-extern int fn(int a, int b) {
+#ifdef _WIN32
+#define EXPORT __declspec(dllexport)
+#else
+#define EXPORT extern
+#endif
+
+EXPORT int fn(int a, int b) {
   if (a < b) {
     int sum = a + b;
     return sum; // breakpoint 2
diff --git a/lldb/test/API/python_api/block/main.c b/lldb/test/API/python_api/block/main.c
index 8200ecf5bdf4f..7e862f0e1a3c1 100644
--- a/lldb/test/API/python_api/block/main.c
+++ b/lldb/test/API/python_api/block/main.c
@@ -1,6 +1,10 @@
 #include <stdio.h>
 
+#ifdef _WIN32
+__declspec(dllimport) int fn(int a, int b);
+#else
 extern int fn(int a, int b);
+#endif
 
 int main(int argc, char const *argv[]) {
   int a = 3;

``````````

</details>


https://github.com/llvm/llvm-project/pull/184647