[Lldb-commits] [lldb] [lldb] Expose block equality with SBBlock. (PR #184222)

[Michael Buch via lldb-commits]

Michael137 wrote:

> Also:
> 
> ```
> 
> $ ninja && ./bin/lldb-dotest -p TestGdbRemote_qRegisterInfo.py
> 
> [3/3] Running utility command for lldb-python
> 
> /usr/bin/python3.10 /home/davspi01/llvm-project/lldb/test/API/dotest.py --arch aarch64 -u CXXFLAGS -u CFLAGS --build-dir /home/davspi01/build-llvm-aarch64/lldb-test-build.noindex --executable /home/davspi01/build-llvm-aarch64/./bin/lldb --compiler /home/davspi01/build-llvm-aarch64/./bin/clang --dsymutil /home/davspi01/build-llvm-aarch64/./bin/dsymutil --make /usr/bin/gmake --lldb-libs-dir /home/davspi01/build-llvm-aarch64/./lib --llvm-tools-dir /home/davspi01/build-llvm-aarch64/./bin --lldb-obj-root /home/davspi01/build-llvm-aarch64/tools/lldb --cmake-build-type Release -p TestGdbRemote_qRegisterInfo.py
> 
> lldb version 23.0.0git (https://github.com/llvm/llvm-project.git revision 8ac00ba7f9f1b50732ae568de8ed44cce9b2a303)
> 
>   clang revision 8ac00ba7f9f1b50732ae568de8ed44cce9b2a303
> 
>   llvm revision 8ac00ba7f9f1b50732ae568de8ed44cce9b2a303
> 
> Skipping the following test categories: libc++, msvcstl, dsym, pdb, gmodules, debugserver, objc
> 
> Traceback (most recent call last):
> 
>   File "/home/davspi01/llvm-project/lldb/test/API/dotest.py", line 8, in <module>
> 
>     lldbsuite.test.run_suite()
> 
>   File "/home/davspi01/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1130, in run_suite
> 
>     visit("Test", dirpath, filenames)
> 
>   File "/home/davspi01/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 727, in visit
> 
>     raise Exception("Found multiple tests with the name %s" % name)
> 
> Exception: Found multiple tests with the name TestBlocks.py
> 
> ```
> 
> 
> 
> I think this was not caught by the linter because it's two file names being the same rather than two classes or methods being the same name. Right @Michael137 ?

Correct
The "each test requires a unique name" issue is something @JDevlieghere and @labath said we should be able to relax. But i dont think anyone has properly looked into addressing it

https://github.com/llvm/llvm-project/pull/184222