[Lldb-commits] [lldb] [lldb][NFC] Use UnimplementedError for GetSDKFromDebugInfo (PR #184199)

[Michael Buch via lldb-commits]

Michael137 wrote:

> > > We can now differentiate unimplemented errors from actual errors that may be useful to users.
> > 
> > 
> > Could you elaborate on this? Possibly a screenshot?
> 
> Context it is from downstream. when Initialising the swift ast context. any error that the user should beware of is shown to the user. In the case of windows and linux the `GetSDKFromDebugInfo` is unimplemented and we return an error. this gets forwarded to the user every time on startup but there is nothing they can do about it.

I see, so the idea is that the Swift plugin "catches" the `UnimplementedError` and doesn't print it in that case?

Would be nice if we didn't loose information about what wasn't implemented and by which platform. Possibly adding a `message` string to the `UnimplementedError` constructor or something

https://github.com/llvm/llvm-project/pull/184199