[Lldb-commits] [lldb] [lldb][NFC] Use UnimplementedError for GetSDKFromDebugInfo (PR #184199)

[Ebuka Ezike via lldb-commits]

================
@@ -478,11 +477,10 @@ class Platform : public PluginInterface {
   ///
   /// \param[in] unit The CU
   ///
-  /// \returns A parsed XcodeSDK object if successful, an Error otherwise. 
-  virtual llvm::Expected<XcodeSDK> GetSDKPathFromDebugInfo(CompileUnit &unit) {
-    return llvm::createStringError(
-        llvm::formatv("{0} not implemented for '{1}' platform.",
-                      LLVM_PRETTY_FUNCTION, GetName()));
+  /// \returns A parsed XcodeSDK object if successful, an Error otherwise.
+  virtual llvm::Expected<XcodeSDK>
+  GetSDKPathFromDebugInfo(CompileUnit & /*unit*/) {
----------------
da-viper wrote:

Because it is not used in the function. I could change it back if it is against the coding convention. 

https://github.com/llvm/llvm-project/pull/184199