[Lldb-commits] [lldb] [llvm] [lldb][Process/FreeBSDKernelCore] Improve DoUpdateThreadList() (PR #183981)

[David Spickett via lldb-commits]

================
@@ -225,11 +235,23 @@ bool ProcessFreeBSDKernelCore::DoUpdateThreadList(ThreadList &old_thread_list,
     // the end of the list, so we have to walk it backwards. First collect all
     // the processes in the list order.
     std::vector<lldb::addr_t> process_addrs;
-    for (lldb::addr_t proc =
-             ReadPointerFromMemory(FindSymbol("allproc"), error);
-         proc != 0 && proc != LLDB_INVALID_ADDRESS;
-         proc = ReadPointerFromMemory(proc + offset_p_list, error)) {
-      process_addrs.push_back(proc);
+
+    lldb::addr_t zombproc_addr = FindSymbol("zombproc");
----------------
DavidSpickett wrote:

Does doing this first effect the order of displayed processes?

I think not because you do some sorting later, by PID, right?

Also, is there a way for a user to tell a process is a zombie, is that something they'd want to do? You don't have to add one, I'm just curious if we already highlight it somehow, or you'd have to manually look in the kernel structures to confirm it.

https://github.com/llvm/llvm-project/pull/183981