[Lldb-commits] [lldb] [llvm] [lldb][Process/FreeBSDKernelCore] Implement DoWriteMemory() (PR #183553)

[David Spickett via lldb-commits]

================
@@ -221,11 +216,12 @@ Changes to LLDB
 * Support for libfbsdvmcore has been removed. As a result, FreeBSD kernel dump debugging is now only
   available on FreeBSD hosts. Live kernel debugging through the GDB remote protocol is still available
   from any platform.
-* Support for ARM has been added.
 * The crashed thread is now automatically selected on start.
 * Threads are listed in incrmental order by pid then by tid.
 * Unread kernel messages saved in msgbufp are now printed when lldb starts. This information is printed only
   when lldb is in the interactive mode (i.e. not in batch mode).
+* Writing to core is now supported. For safety reasons, this feature is off by default. To enable it,
----------------
DavidSpickett wrote:

You could also note that this writing is delegated to kvm and kvm only implements it for /dev/mem at this time. Which is not our fault but useful for users to know.

Something like this, adjust the terminology as needed for a FreeBSD audience:
This setting is available when using `/dev/mem`, or a kernel dump. However, writes are implemented using `kvm_write`, which does not support writing to kernel dumps. So writes to a kernel dump will still fail when the setting is `false`.

https://github.com/llvm/llvm-project/pull/183553