[Lldb-commits] [lldb] [LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[Jonas Devlieghere via lldb-commits]

================
@@ -1465,6 +1465,101 @@ bool DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
   return InstrDesc.isAuthenticated() || IsBrkC47x;
 }
 
+static void
+UpdateSubtargetFeatures(const llvm::SubtargetFeatures &subtarget_features,
+                        std::string &user_feature_overrides) {
+
+  // Extract the default features string from the SubtargetFeatures object.
+  // We must store this in a std::string variable to ensure the memory exists
+  // for the StringRef to point to during the execution of this function.
+  std::string default_features_storage = subtarget_features.getString();
+  llvm::StringRef default_features = default_features_storage;
+
+  // If the user has not provided any overrides AND defaults exist,
+  // then simply use the default feature string.
----------------
JDevlieghere wrote:

Again, this is literally just describing what the code does. This smells like AI?

https://github.com/llvm/llvm-project/pull/147990