[Lldb-commits] [lldb] [lldb][ARM] Support thread local variables on ARM Linux (PR #181315)

[David Spickett via lldb-commits]

================
@@ -345,7 +346,14 @@ class DYLDRendezvous {
   /// supplied by the runtime linker.
   bool TakeSnapshot(SOEntryList &entry_list);
 
-  enum PThreadField { eSize, eNElem, eOffset };
+  /// For the definitions of the metadata entries, see
+  /// <glibc>/nptl_db/(db_info.c, structs.def, thread_dbP.h).
----------------
DavidSpickett wrote:

Yes, it should. My worry was that we would return misleading values for other libcs.

I don't think that's the case because the existing GetThreadInfo looks up a bunch of glibc specific symbols, and you've added one more, so it's even more sensitive now.

All the callers of GetThreadInfo bail early if it's invalid, so we won't be returning any value for other libcs.

https://github.com/llvm/llvm-project/pull/181315