[Lldb-commits] [lldb] [lldb-dap] Validate utf8 protocol messages. (PR #181261)

Tue Feb 17 14:10:17 PST 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/37346

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
102.844 [368/8/5208] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Variables.cpp.o
103.626 [367/8/5209] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Watchpoint.cpp.o
105.066 [366/8/5210] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/AttachRequestHandler.cpp.o
105.520 [365/8/5211] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/CancelRequestHandler.cpp.o
105.791 [364/8/5212] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/CompileUnitsRequestHandler.cpp.o
105.901 [363/8/5213] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/BreakpointLocationsRequestHandler.cpp.o
106.676 [362/8/5214] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/CompletionsRequestHandler.cpp.o
106.851 [361/8/5215] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/ConfigurationDoneRequestHandler.cpp.o
107.435 [360/8/5216] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/ContinueRequestHandler.cpp.o
107.701 [359/8/5217] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o
FAILED: tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o 
/opt/ccache/bin/g++ -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/tools/lldb-dap -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/llvm/../clang/include -I/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/build/tools/lldb/../clang/include -isystem /usr/include/libxml2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -std=c++17 -MD -MT tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o -MF tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o.d -o tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DataBreakpointInfoRequestHandler.cpp.o -c /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Handler/DataBreakpointInfoRequestHandler.cpp
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Handler/DataBreakpointInfoRequestHandler.cpp: In member function ‘virtual llvm::Expected<lldb_dap::protocol::DataBreakpointInfoResponseBody> lldb_dap::DataBreakpointInfoRequestHandler::Run(const lldb_dap::protocol::DataBreakpointInfoArguments&) const’:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Handler/DataBreakpointInfoRequestHandler.cpp:97:46: error: invalid user-defined conversion from ‘const lldb_dap::protocol::String’ to ‘const string&’ {aka ‘const std::__cxx11::basic_string<char>&’} [-fpermissive]
   97 |       return llvm::make_error<DAPError>(args.name + " is not a valid address",
      |                                         ~~~~~^~~~
In file included from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/DAPTypes.h:19,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/ProtocolTypes.h:23,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/ExceptionBreakpoint.h:13,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/DAP.h:14,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Handler/DataBreakpointInfoRequestHandler.cpp:9:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/ProtocolBase.h:66:3: note: candidate is: ‘lldb_dap::protocol::String::operator std::string&()’ <near match>
   66 |   operator std::string &() { return m_str; }
      |   ^~~~~~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/ProtocolBase.h:66:3: note:   passing ‘const lldb_dap::protocol::String*’ as ‘this’ argument discards qualifiers
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Handler/DataBreakpointInfoRequestHandler.cpp:97:53: error: passing ‘const lldb_dap::protocol::String’ as ‘this’ argument discards qualifiers [-fpermissive]
   97 |       return llvm::make_error<DAPError>(args.name + " is not a valid address",
      |                                                     ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/DAPTypes.h:19,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/ProtocolTypes.h:23,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/ExceptionBreakpoint.h:13,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/DAP.h:14,
                 from /home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Handler/DataBreakpointInfoRequestHandler.cpp:9:
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/ProtocolBase.h:66:3: note:   in call to ‘lldb_dap::protocol::String::operator std::string&()’
   66 |   operator std::string &() { return m_str; }
      |   ^~~~~~~~
/home/buildbot/buildbot-root/cross-project-tests-sie-ubuntu/llvm-project/lldb/tools/lldb-dap/Protocol/ProtocolBase.h:122:44: note:   initializing argument 1 of ‘lldb_dap::protocol::String lldb_dap::protocol::operator+(const string&, const lldb_dap::protocol::String&)’
  122 | inline String operator+(const std::string &LHS, const String &RHS) {
      |                         ~~~~~~~~~~~~~~~~~~~^~~
109.771 [359/7/5218] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/EvaluateRequestHandler.cpp.o
109.878 [359/6/5219] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DisconnectRequestHandler.cpp.o
110.490 [359/5/5220] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/DisassembleRequestHandler.cpp.o
110.850 [359/4/5221] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/InitializeRequestHandler.cpp.o
111.346 [359/3/5222] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/ExceptionInfoRequestHandler.cpp.o
111.385 [359/2/5223] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/LocationsRequestHandler.cpp.o
111.636 [359/1/5224] Building CXX object tools/lldb/tools/lldb-dap/CMakeFiles/lldbDAP.dir/Handler/LaunchRequestHandler.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/181261