[Lldb-commits] [lldb] [lldb][windows] release the ConPTY instead of copying its reference (PR #181811)

Charles Zablit via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 17 14:04:15 PST 2026


================
@@ -130,7 +130,7 @@ class ProcessLaunchInfo : public ProcessInfo {
 
   PTY &GetPTY() const { return *m_pty; }
 
-  std::shared_ptr<PTY> GetPTYSP() const { return m_pty; }
+  std::shared_ptr<PTY> ReleasePTY() { return std::move(m_pty); }
----------------
charles-zablit wrote:

Not really, there is `ReleasePrimaryFileDescriptor` in the POSIX PTY implementation, but that's not applied to a `std::shared_ptr`.

I have renamed the method to `TakePTY`.

https://github.com/llvm/llvm-project/pull/181811


More information about the lldb-commits mailing list