[Lldb-commits] [lldb] [lldb][Process/FreeBSDKernel] Remove libfbsdvmcore support (PR #181283)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> The current libfbsdvmcore (fvc) implementation is copying FreeBSD's kvm source code and making it cross-platform. The biggest problem is here is that any modifications (e.g. bug fixes) should be backported to fvc, but fvc has no update for the last five years (https://github.com/Moritz-Systems/libfbsdvmcore) while modification still happen on the FreeBSD kvm side (https://github.com/freebsd/freebsd-src/commits/main/lib/libkvm). Since fvc isn't catching up with kvm, this makes implementing new features based on newer kvm harder. (and again, developers need to test on both platforms while fvc is undertested and we don't hear any feedbacks from the fvc side)

Thanks for the context. That sounds like a totally reasonable motivation for this change. And apologies if I came across as pushing back on the idea, that wasn't my intention.

https://github.com/llvm/llvm-project/pull/181283