[Lldb-commits] [lldb] 68cc809 - [lldb] Flatten GetCompilerType-MaybeCalculateCompleteType (NFC) (#181215)

[via lldb-commits]

Author: Dave Lee
Date: 2026-02-12T13:47:50-08:00
New Revision: 68cc809581539e58faeb33bf0841fd1ccbaa7a6d

URL: https://github.com/llvm/llvm-project/commit/68cc809581539e58faeb33bf0841fd1ccbaa7a6d
DIFF: https://github.com/llvm/llvm-project/commit/68cc809581539e58faeb33bf0841fd1ccbaa7a6d.diff

LOG: [lldb] Flatten GetCompilerType-MaybeCalculateCompleteType (NFC) (#181215)

`MaybeCalculateCompleteType` is not overridden anywhere, and is called
only from `GetCompilerType`.

Added: 
    

Modified: 
    lldb/include/lldb/ValueObject/ValueObject.h
    lldb/source/ValueObject/ValueObject.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/ValueObject/ValueObject.h b/lldb/include/lldb/ValueObject/ValueObject.h
index 8a528bad15f94..020b4a97cfc92 100644
--- a/lldb/include/lldb/ValueObject/ValueObject.h
+++ b/lldb/include/lldb/ValueObject/ValueObject.h
@@ -349,7 +349,7 @@ class ValueObject {
 
   void SetNeedsUpdate();
 
-  CompilerType GetCompilerType() { return MaybeCalculateCompleteType(); }
+  CompilerType GetCompilerType();
 
   // this vends a TypeImpl that is useful at the SB API layer
   virtual TypeImpl GetTypeImpl() { return TypeImpl(GetCompilerType()); }
@@ -1105,7 +1105,6 @@ class ValueObject {
   virtual void DoUpdateChildrenAddressType(ValueObject &valobj) {};
 
 private:
-  virtual CompilerType MaybeCalculateCompleteType();
   void UpdateChildrenAddressType() {
     GetRoot()->DoUpdateChildrenAddressType(*this);
   }

diff  --git a/lldb/source/ValueObject/ValueObject.cpp b/lldb/source/ValueObject/ValueObject.cpp
index af67c1c93182c..da9c84a4fa221 100644
--- a/lldb/source/ValueObject/ValueObject.cpp
+++ b/lldb/source/ValueObject/ValueObject.cpp
@@ -249,7 +249,7 @@ void ValueObject::ClearDynamicTypeInformation() {
   SetSyntheticChildren(lldb::SyntheticChildrenSP());
 }
 
-CompilerType ValueObject::MaybeCalculateCompleteType() {
+CompilerType ValueObject::GetCompilerType() {
   CompilerType compiler_type(GetCompilerTypeImpl());
 
   if (m_flags.m_did_calculate_complete_objc_class_type) {