[Lldb-commits] [lldb] [lldb][macOS] Index shared cache files by UUID & filename (PR #180874)

[Jonas Devlieghere via lldb-commits]

================
@@ -709,7 +726,12 @@ bool GetImages(llvm::StringMap<SharedCacheImageInfo> **images,
   void CreateSharedCacheInfoLLDBsVirtualMemory();
   bool CreateHostSharedCacheImageList();
 
-  std::map<UUID, llvm::StringMap<SharedCacheImageInfo>> m_caches;
+  std::vector<SharedCacheImageInfo> m_file_infos;
+  llvm::SmallDenseMap<UUID, llvm::StringMap<SharedCacheImageInfo *>>
----------------
JDevlieghere wrote:

A `StringMap` is going to store a copy of the string key. If we're already using a ConstString for the filenames, we should use `DenseMap<ConstString,...>` here and avoid duplicating the memory. 

https://github.com/llvm/llvm-project/pull/180874