[Lldb-commits] [lldb] Reland "[lldb] Fix TSan report" (PR #181004)

[David Spickett via lldb-commits]

================
@@ -88,8 +88,18 @@ extern "C"
     // TODO: dlsym won't work on Windows.
     void *dlsym(void* handle, const char* symbol);
     int (*ptr__tsan_get_report_loc_object_type)(void *report, unsigned long idx, const char **object_type);
-}
+)"
+#if defined(__linux__)
----------------
DavidSpickett wrote:

We are at least in spirit a cross debugger. There is a bot for Linux -> Windows (https://lab.llvm.org/buildbot/#/builders/197) but I expect them to be disabled there. Not sure it even has tsan yet. And this line above ofc:
```
// TODO: dlsym won't work on Windows.
```
Windows -> Linux would be incorrect though.

> Similarly with cross-compilation.

That will be ok I think. If I'm on Mac building an lldb to run on Linux, `__linux__` will be defined. As long as you local debug on Linux using that lldb ofc.

What is the solution here if you wanted it to be dynamic, is it a lot of work? For some definition of "a lot", we can be ok with this as a known limitation.

https://github.com/llvm/llvm-project/pull/181004