[Lldb-commits] [lldb] 5fef367 - [LLDB][NativePDB] Use pointer and not pointee size for pointer constants (#180987)

[via lldb-commits]

Author: Leonard Grey
Date: 2026-02-12T09:35:27-05:00
New Revision: 5fef36767fe8d852a65ef3a4c020c677bc80799b

URL: https://github.com/llvm/llvm-project/commit/5fef36767fe8d852a65ef3a4c020c677bc80799b
DIFF: https://github.com/llvm/llvm-project/commit/5fef36767fe8d852a65ef3a4c020c677bc80799b.diff

LOG: [LLDB][NativePDB] Use pointer and not pointee size for pointer constants (#180987)

Follow-up from
https://github.com/llvm/llvm-project/pull/180612#pullrequestreview-3780142672

This was introduced in 2af3416618e6 and not fundamentally changed since.
The review (https://reviews.llvm.org/D54452) doesn't mention any
motivation for why we would want the pointee size/signedness here. As
@Nerixyz points out, only a null pointer can be `S_CONSTANT` anyway.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
index 75adf7302f00c..ff5017e611fc8 100644
--- a/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
+++ b/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
@@ -91,7 +91,7 @@ static std::pair<size_t, bool> GetIntegralTypeInfo(TypeIndex ti,
   case LF_POINTER: {
     PointerRecord pr;
     llvm::cantFail(TypeDeserializer::deserializeAs<PointerRecord>(cvt, pr));
-    return GetIntegralTypeInfo(pr.ReferentType, tpi);
+    return {pr.getSize(), false};
   }
   case LF_ENUM: {
     EnumRecord er;