[Lldb-commits] [lldb] [lldb-dap][vscode][windows] check if Python is installed properly before starting lldb-dap (PR #181124)

[Charles Zablit via lldb-commits]

================
@@ -60,6 +61,15 @@ export class LLDBDapServer implements vscode.Disposable {
     }
 
     this.serverInfo = new Promise((resolve, reject) => {
+      if (os.platform() === "win32") {
+        const pythonCheckProcess = child_process.spawnSync(dapPath, ["--check-python"]);
----------------
charles-zablit wrote:

Maybe I should have marked this PR as a draft.

There are a couple of questions which are still unanswered by this patch:
1. What happens if the `lldb-dap` binary is too old and `--check-python` does not exist yet? Should we first run `lldb-dap.exe --version`, parse it and make sure it's recent enough? But that does not work for `main` builds.
2. As you said, what happens if `lldb-dap` is not built with Python support? We could parse a predefined error like "was not built with Python support".

https://github.com/llvm/llvm-project/pull/181124