[Lldb-commits] [lldb] [lldb-dap][windows] add support for out of PATH python.dll resolution (PR #179306)

[Martin Storsjö via lldb-commits]

mstorsjo wrote:

> Thanks for the detailed explanation, I have opened a fix here: #180976.

Thanks! I went ahead and merged it yesterday, to unbreak my nightly build.

> Building at desk works fine, I think that the fix is semantically correct, as `PythonPathSetup` does not require LLVMSupport.

Actually, I think it's even more of a structural thing; many parts of LLDB do use LLVMSupport to some extent (e.g. mostly everything uses `StringRef` in one form or another under the hood), but none of the LLDB libraries explicitly declare a dependency on LLVMSupport. (There's no hits for `LLVMSupport` anywhere in the lldb tree). I think the handling of linking LLVMSupport the right way is handled by the LLDB cmake helper macros somewhere.

https://github.com/llvm/llvm-project/pull/179306