[Lldb-commits] [lldb] [LLDB][NativePDB] Use pointer and pointee size for pointer constants (PR #180987)

[Leonard Grey via lldb-commits]

https://github.com/speednoisemovement created https://github.com/llvm/llvm-project/pull/180987

Follow-up from https://github.com/llvm/llvm-project/pull/180612#pullrequestreview-3780142672

This was introduced in 2af3416618e6 and not fundamentally changed since. The review (https://reviews.llvm.org/D54452) doesn't mention any motivation for why we would want the pointee size/signedness here. As @Nerixyz points out, only a null pointer can be `S_CONSTANT` anyway.

>From d45ddce97044a395b686c5aeaa63ff6199738977 Mon Sep 17 00:00:00 2001
From: Leonard Grey <leonard at leonardgrey.com>
Date: Wed, 11 Feb 2026 13:12:32 -0500
Subject: [PATCH] [LLDB][NativePDB] Use pointer and pointee size for pointer
 constants

---
 .../Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
index 75adf7302f00c..ff5017e611fc8 100644
--- a/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
+++ b/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
@@ -91,7 +91,7 @@ static std::pair<size_t, bool> GetIntegralTypeInfo(TypeIndex ti,
   case LF_POINTER: {
     PointerRecord pr;
     llvm::cantFail(TypeDeserializer::deserializeAs<PointerRecord>(cvt, pr));
-    return GetIntegralTypeInfo(pr.ReferentType, tpi);
+    return {pr.getSize(), false};
   }
   case LF_ENUM: {
     EnumRecord er;