[Lldb-commits] [lldb] [lldb-dap][windows] add support for out of PATH python.dll resolution (PR #179306)

[Charles Zablit via lldb-commits]

================
@@ -523,6 +524,11 @@ int main(int argc, char *argv[]) {
                         "~/Library/Logs/DiagnosticReports/.\n");
 #endif
 
+#ifdef _WIN32
+  if (llvm::Error error = SetupPythonRuntimeLibrary())
+    llvm::WithColor::error() << llvm::toString(std::move(error)) << '\n';
----------------
charles-zablit wrote:

It's better if we do not: we discussed this with @mstorsjo in the original patch for the Python check in lldb (https://github.com/llvm/llvm-project/pull/162509).

We could not get CMake to reliably get the name of the Python shared library on Windows. It was either `python310.dll` or `libpython-310.dll`. We agreed to not return early if we can't load Python to avoid false positives.

In swiftlang, since we control how we build the installer and have fewer build configurations, we do return early now.

https://github.com/llvm/llvm-project/pull/179306