[Lldb-commits] [lldb] [llvm] [llvm][lldb] Add check for incorrect target features (PR #180901)

[David Spickett via lldb-commits]

================
@@ -351,6 +351,31 @@ class Target {
   /// InstrumentManager, if registered (default = nullptr).
   InstrumentManagerCtorTy InstrumentManagerCtorFn = nullptr;
 
+  bool isSignedFeatureList(StringRef FeaturesString) const {
----------------
DavidSpickett wrote:

Unless you have a really good reason for it to be in a header, put it in the c++ file.

Also this needs a docstring to explain what Signed means.

I'm not sure I'd call it signed, I know what you mean because of the + and -, but it's also checking formatting. So a more accurate, enterprise ready, name would be isValidFeatureListFormat. Something like that.

https://github.com/llvm/llvm-project/pull/180901