[Lldb-commits] [lldb] Revert "[lldb-dap] fix executable substitution in tests (#179685)" (PR #180241)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

This reverts commit 082a47d8944da242993bf28980b07f2c8c3df4a6.

`ToolSubst` should only be used explicitely for passing `extra_args`. 

---
Full diff: https://github.com/llvm/llvm-project/pull/180241.diff


1 Files Affected:

- (modified) lldb/test/Shell/helper/toolchain.py (+1-3) 


``````````diff
diff --git a/lldb/test/Shell/helper/toolchain.py b/lldb/test/Shell/helper/toolchain.py
index 5803ecb8d96c1..66664561a249d 100644
--- a/lldb/test/Shell/helper/toolchain.py
+++ b/lldb/test/Shell/helper/toolchain.py
@@ -167,9 +167,7 @@ def use_lldb_substitutions(config):
             unresolved="ignore",
         ),
         "lldb-test",
-        ToolSubst(
-            "%lldb-dap", command=FindTool("lldb-dap"), extra_args=[], unresolved="fatal"
-        ),
+        "lldb-dap",
         ToolSubst(
             "%build", command="'" + sys.executable + "'", extra_args=build_script_args
         ),

``````````

</details>


https://github.com/llvm/llvm-project/pull/180241