[Lldb-commits] [lldb] Revert "[lldb-dap] fix executable substitution in tests (#179685)" (PR #180241)

Charles Zablit via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 6 09:33:38 PST 2026


https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/180241

This reverts commit 082a47d8944da242993bf28980b07f2c8c3df4a6.

`ToolSubst` should only be used explicitely for passing `extra_args`. 

>From 0acc92e83c49db95fd913c3c1f4d8392080e713a Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Fri, 6 Feb 2026 18:32:05 +0100
Subject: [PATCH] Revert "[lldb-dap] fix executable substitution in tests
 (#179685)"

This reverts commit 082a47d8944da242993bf28980b07f2c8c3df4a6.
---
 lldb/test/Shell/helper/toolchain.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lldb/test/Shell/helper/toolchain.py b/lldb/test/Shell/helper/toolchain.py
index 5803ecb8d96c1..66664561a249d 100644
--- a/lldb/test/Shell/helper/toolchain.py
+++ b/lldb/test/Shell/helper/toolchain.py
@@ -167,9 +167,7 @@ def use_lldb_substitutions(config):
             unresolved="ignore",
         ),
         "lldb-test",
-        ToolSubst(
-            "%lldb-dap", command=FindTool("lldb-dap"), extra_args=[], unresolved="fatal"
-        ),
+        "lldb-dap",
         ToolSubst(
             "%build", command="'" + sys.executable + "'", extra_args=build_script_args
         ),



More information about the lldb-commits mailing list