[Lldb-commits] [lldb] Fix the modal private state thread we use for running expressions on the private state thread (PR #179799)

via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 5 10:20:58 PST 2026


================
@@ -5970,22 +6044,26 @@ void Process::ClearPreResumeAction(PreResumeActionCallback callback, void *baton
 }
 
 ProcessRunLock &Process::GetRunLock() {
-  if (Process::CurrentThreadIsPrivateStateThread())
-    return m_private_run_lock;
-  return m_public_run_lock;
+  if (Process::CurrentThreadPosesAsPrivateStateThread())
+    return m_current_private_state_thread->GetRunLock();
+  else
+    return m_current_private_state_thread->GetRunLock();
----------------
jimingham wrote:

TTTT, I don't understand this part of the llvm coding conventions.  The logical structure is "if A return X else return Y".  I've never understood why "if A return X; return Y" is a clearer way to state this.  But I still comply.

https://github.com/llvm/llvm-project/pull/179799


More information about the lldb-commits mailing list