[Lldb-commits] [lldb] 35ada11 - [lldb-dap] Improving stability of TestDAP_launch_commands. (#179783)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 5 08:19:19 PST 2026
Author: John Harrison
Date: 2026-02-05T08:19:14-08:00
New Revision: 35ada11f1b4b9ca51f8b07af4cc9a7aa3400028e
URL: https://github.com/llvm/llvm-project/commit/35ada11f1b4b9ca51f8b07af4cc9a7aa3400028e
DIFF: https://github.com/llvm/llvm-project/commit/35ada11f1b4b9ca51f8b07af4cc9a7aa3400028e.diff
LOG: [lldb-dap] Improving stability of TestDAP_launch_commands. (#179783)
Improving stability of the TestDAP_launch_commands test.
When collecting output for verifying 'stopCommands' we were not waiting
for the output to finish, which could cause issues if the test is
running very fast.
Added:
Modified:
lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_commands.py
Removed:
################################################################################
diff --git a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_commands.py b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_commands.py
index 19da25b3df165..48398e5915069 100644
--- a/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_commands.py
+++ b/lldb/test/API/tools/lldb-dap/launch/TestDAP_launch_commands.py
@@ -47,7 +47,7 @@ def test(self):
# Get output from the console. This should contain both the
# "initCommands" and the "preRunCommands".
- output = self.get_console()
+ output = self.collect_console(pattern=postRunCommands[-1])
# Verify all "initCommands" were found in console output
self.verify_commands("initCommands", output, initCommands)
# Verify all "preRunCommands" were found in console output
@@ -71,14 +71,14 @@ def test(self):
# Get output from the console. This should contain both the
# "stopCommands" that were run after the first breakpoint was hit
self.continue_to_breakpoints(breakpoint_ids)
- output = self.get_console()
+ output = self.collect_console(pattern=stopCommands[-1])
self.verify_commands("stopCommands", output, stopCommands)
# Continue again and hit the second breakpoint.
# Get output from the console. This should contain both the
# "stopCommands" that were run after the second breakpoint was hit
self.continue_to_breakpoints(breakpoint_ids)
- output = self.get_console()
+ output = self.collect_console(pattern=stopCommands[-1])
self.verify_commands("stopCommands", output, stopCommands)
# Continue until the program exits
More information about the lldb-commits
mailing list